is the following code vulnerable to dom-based xss?
0
A security auditor reported me that the following snippet of html/js is vulnerable to XSS.
In short this is it:
if (window.location.hash) {
var hash = window.location.hash.substring(1);
var elem = $('#reports_nav_links .' + hash);
var path = elem.data('path');the security auditor didn't provide any detail on how this can be leveraged to get an alert box showing.
The url generated by default is:
/report#q1
If it's vulnerable, could you also please provide me an example of payload that will show an alert box with this code?
Thanks,
Dan.
javascript security dom xss
asked Nov 22 at 19:37
Dan Lowies
1
add a comment |
0
A security auditor reported me that the following snippet of html/js is vulnerable to XSS.
In short this is it:
if (window.location.hash) {
var hash = window.location.hash.substring(1);
var elem = $('#reports_nav_links .' + hash);
var path = elem.data('path');the security auditor didn't provide any detail on how this can be leveraged to get an alert box showing.
The url generated by default is:
/report#q1
If it's vulnerable, could you also please provide me an example of payload that will show an alert box with this code?
Thanks,
Dan.
javascript security dom xss
asked Nov 22 at 19:37
Dan Lowies
1
Can't see it. jQuery only evaluates the selector as string and throws exception if it can't parse it properly as valid selector and it only uses string methods for that parsing
– charlietfl
Nov 22 at 19:42
I'm guessing they have a policy that since$()can also accept html that can then be injected in dom that any unsanitized variables that are assigned from external sources used inside$()are a security issue
– charlietfl
Nov 22 at 19:53
@charlietfl You are right, so you are saying that the issue is valid? What payload could be used to trigger an alert box for example?
– Dan Lowies
Nov 22 at 19:55
I don't see it being possible to execute anything in this use case since that leading#indicates it is being used as a selector. The case where it is more problematic ishash = "<script>....</script>"; $(hash).appendTo('body')
– charlietfl
Nov 22 at 19:56
Even then jQuery doesn't like script tags either
– charlietfl
Nov 22 at 20:04
add a comment |
0
0
0
A security auditor reported me that the following snippet of html/js is vulnerable to XSS.
In short this is it:
if (window.location.hash) {
var hash = window.location.hash.substring(1);
var elem = $('#reports_nav_links .' + hash);
var path = elem.data('path');the security auditor didn't provide any detail on how this can be leveraged to get an alert box showing.
The url generated by default is:
/report#q1
If it's vulnerable, could you also please provide me an example of payload that will show an alert box with this code?
Thanks,
Dan.
javascript security dom xss
asked Nov 22 at 19:37
Dan Lowies
1
A security auditor reported me that the following snippet of html/js is vulnerable to XSS.
In short this is it:
if (window.location.hash) {
var hash = window.location.hash.substring(1);
var elem = $('#reports_nav_links .' + hash);
var path = elem.data('path');the security auditor didn't provide any detail on how this can be leveraged to get an alert box showing.
The url generated by default is:
/report#q1
If it's vulnerable, could you also please provide me an example of payload that will show an alert box with this code?
Thanks,
Dan.
if (window.location.hash) {
var hash = window.location.hash.substring(1);
var elem = $('#reports_nav_links .' + hash);
var path = elem.data('path');if (window.location.hash) {
var hash = window.location.hash.substring(1);
var elem = $('#reports_nav_links .' + hash);
var path = elem.data('path');javascript security dom xss
javascript security dom xss
asked Nov 22 at 19:37
Dan Lowies
1
asked Nov 22 at 19:37
Dan Lowies
1
asked Nov 22 at 19:37
Dan Lowies
1
asked Nov 22 at 19:37
Dan Lowies
1
asked Nov 22 at 19:37
Dan Lowies
1
1
Can't see it. jQuery only evaluates the selector as string and throws exception if it can't parse it properly as valid selector and it only uses string methods for that parsing
– charlietfl
Nov 22 at 19:42
I'm guessing they have a policy that since$()can also accept html that can then be injected in dom that any unsanitized variables that are assigned from external sources used inside$()are a security issue
– charlietfl
Nov 22 at 19:53
@charlietfl You are right, so you are saying that the issue is valid? What payload could be used to trigger an alert box for example?
– Dan Lowies
Nov 22 at 19:55
I don't see it being possible to execute anything in this use case since that leading#indicates it is being used as a selector. The case where it is more problematic ishash = "<script>....</script>"; $(hash).appendTo('body')
– charlietfl
Nov 22 at 19:56
Even then jQuery doesn't like script tags either
– charlietfl
Nov 22 at 20:04
add a comment |
Can't see it. jQuery only evaluates the selector as string and throws exception if it can't parse it properly as valid selector and it only uses string methods for that parsing
– charlietfl
Nov 22 at 19:42
I'm guessing they have a policy that since$()can also accept html that can then be injected in dom that any unsanitized variables that are assigned from external sources used inside$()are a security issue
– charlietfl
Nov 22 at 19:53
@charlietfl You are right, so you are saying that the issue is valid? What payload could be used to trigger an alert box for example?
– Dan Lowies
Nov 22 at 19:55
I don't see it being possible to execute anything in this use case since that leading#indicates it is being used as a selector. The case where it is more problematic ishash = "<script>....</script>"; $(hash).appendTo('body')
– charlietfl
Nov 22 at 19:56
Even then jQuery doesn't like script tags either
– charlietfl
Nov 22 at 20:04
Can't see it. jQuery only evaluates the selector as string and throws exception if it can't parse it properly as valid selector and it only uses string methods for that parsing
– charlietfl
Nov 22 at 19:42
Can't see it. jQuery only evaluates the selector as string and throws exception if it can't parse it properly as valid selector and it only uses string methods for that parsing
– charlietfl
Nov 22 at 19:42
I'm guessing they have a policy that since
$() can also accept html that can then be injected in dom that any unsanitized variables that are assigned from external sources used inside $() are a security issue– charlietfl
Nov 22 at 19:53
I'm guessing they have a policy that since
$() can also accept html that can then be injected in dom that any unsanitized variables that are assigned from external sources used inside $() are a security issue– charlietfl
Nov 22 at 19:53
@charlietfl You are right, so you are saying that the issue is valid? What payload could be used to trigger an alert box for example?
– Dan Lowies
Nov 22 at 19:55
@charlietfl You are right, so you are saying that the issue is valid? What payload could be used to trigger an alert box for example?
– Dan Lowies
Nov 22 at 19:55
I don't see it being possible to execute anything in this use case since that leading
# indicates it is being used as a selector. The case where it is more problematic is hash = "<script>....</script>"; $(hash).appendTo('body')– charlietfl
Nov 22 at 19:56
I don't see it being possible to execute anything in this use case since that leading
# indicates it is being used as a selector. The case where it is more problematic is hash = "<script>....</script>"; $(hash).appendTo('body')– charlietfl
Nov 22 at 19:56
Even then jQuery doesn't like script tags either
– charlietfl
Nov 22 at 20:04
Even then jQuery doesn't like script tags either
– charlietfl
Nov 22 at 20:04
add a comment |
active
oldest
votes
Your Answer
StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53437174%2fis-the-following-code-vulnerable-to-dom-based-xss%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
active
oldest
votes
active
oldest
votes
active
oldest
votes
active
oldest
votes
draft saved
draft discarded
Thanks for contributing an answer to Stack Overflow!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
draft saved
draft discarded
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53437174%2fis-the-following-code-vulnerable-to-dom-based-xss%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Can't see it. jQuery only evaluates the selector as string and throws exception if it can't parse it properly as valid selector and it only uses string methods for that parsing
– charlietfl
Nov 22 at 19:42
I'm guessing they have a policy that since
$()can also accept html that can then be injected in dom that any unsanitized variables that are assigned from external sources used inside$()are a security issue– charlietfl
Nov 22 at 19:53
@charlietfl You are right, so you are saying that the issue is valid? What payload could be used to trigger an alert box for example?
– Dan Lowies
Nov 22 at 19:55
I don't see it being possible to execute anything in this use case since that leading
#indicates it is being used as a selector. The case where it is more problematic ishash = "<script>....</script>"; $(hash).appendTo('body')– charlietfl
Nov 22 at 19:56
Even then jQuery doesn't like script tags either
– charlietfl
Nov 22 at 20:04