DRY Javascript for a real newbie












1














I'm really new at Javascript (and coding in general) and I'm using it in a PDF form I'm creating.



This is what I want to do, but I know there's a better, DRYer way.



Appreciate your help.



this.getField("new_shares_A").display = display.hidden;
this.getField("new_shares_$_A").display = display.hidden;
this.getField("new_deb_A").display = display.hidden;
this.getField("new_deb_$_A").display = display.hidden;
this.getField("std_total_new_A").display = display.hidden;

if(getField("Elect").valueAsString==="A")
{
this.getField("new_shares_A").display = display.visible;
this.getField("new_shares_$_A").display = display.visible;
this.getField("new_deb_A").display = display.visible;
this.getField("new_deb_$_A").display = display.visible;
this.getField("std_total_new_A").display = display.visible;
}









share|improve this question






















  • I'm voting to close this question as off-topic because it belongs on codereview.stackexchange.com
    – Nick
    Nov 23 '18 at 3:25










  • Seriously? A guy comes here looking for help and you tell him to go somewhere else? I thought stack overflow was supposed to be a friendly environment.
    – Rafael
    Nov 23 '18 at 15:04
















1














I'm really new at Javascript (and coding in general) and I'm using it in a PDF form I'm creating.



This is what I want to do, but I know there's a better, DRYer way.



Appreciate your help.



this.getField("new_shares_A").display = display.hidden;
this.getField("new_shares_$_A").display = display.hidden;
this.getField("new_deb_A").display = display.hidden;
this.getField("new_deb_$_A").display = display.hidden;
this.getField("std_total_new_A").display = display.hidden;

if(getField("Elect").valueAsString==="A")
{
this.getField("new_shares_A").display = display.visible;
this.getField("new_shares_$_A").display = display.visible;
this.getField("new_deb_A").display = display.visible;
this.getField("new_deb_$_A").display = display.visible;
this.getField("std_total_new_A").display = display.visible;
}









share|improve this question






















  • I'm voting to close this question as off-topic because it belongs on codereview.stackexchange.com
    – Nick
    Nov 23 '18 at 3:25










  • Seriously? A guy comes here looking for help and you tell him to go somewhere else? I thought stack overflow was supposed to be a friendly environment.
    – Rafael
    Nov 23 '18 at 15:04














1












1








1







I'm really new at Javascript (and coding in general) and I'm using it in a PDF form I'm creating.



This is what I want to do, but I know there's a better, DRYer way.



Appreciate your help.



this.getField("new_shares_A").display = display.hidden;
this.getField("new_shares_$_A").display = display.hidden;
this.getField("new_deb_A").display = display.hidden;
this.getField("new_deb_$_A").display = display.hidden;
this.getField("std_total_new_A").display = display.hidden;

if(getField("Elect").valueAsString==="A")
{
this.getField("new_shares_A").display = display.visible;
this.getField("new_shares_$_A").display = display.visible;
this.getField("new_deb_A").display = display.visible;
this.getField("new_deb_$_A").display = display.visible;
this.getField("std_total_new_A").display = display.visible;
}









share|improve this question













I'm really new at Javascript (and coding in general) and I'm using it in a PDF form I'm creating.



This is what I want to do, but I know there's a better, DRYer way.



Appreciate your help.



this.getField("new_shares_A").display = display.hidden;
this.getField("new_shares_$_A").display = display.hidden;
this.getField("new_deb_A").display = display.hidden;
this.getField("new_deb_$_A").display = display.hidden;
this.getField("std_total_new_A").display = display.hidden;

if(getField("Elect").valueAsString==="A")
{
this.getField("new_shares_A").display = display.visible;
this.getField("new_shares_$_A").display = display.visible;
this.getField("new_deb_A").display = display.visible;
this.getField("new_deb_$_A").display = display.visible;
this.getField("std_total_new_A").display = display.visible;
}






javascript adobe dry






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 23 '18 at 3:05









Rafael

61




61












  • I'm voting to close this question as off-topic because it belongs on codereview.stackexchange.com
    – Nick
    Nov 23 '18 at 3:25










  • Seriously? A guy comes here looking for help and you tell him to go somewhere else? I thought stack overflow was supposed to be a friendly environment.
    – Rafael
    Nov 23 '18 at 15:04


















  • I'm voting to close this question as off-topic because it belongs on codereview.stackexchange.com
    – Nick
    Nov 23 '18 at 3:25










  • Seriously? A guy comes here looking for help and you tell him to go somewhere else? I thought stack overflow was supposed to be a friendly environment.
    – Rafael
    Nov 23 '18 at 15:04
















I'm voting to close this question as off-topic because it belongs on codereview.stackexchange.com
– Nick
Nov 23 '18 at 3:25




I'm voting to close this question as off-topic because it belongs on codereview.stackexchange.com
– Nick
Nov 23 '18 at 3:25












Seriously? A guy comes here looking for help and you tell him to go somewhere else? I thought stack overflow was supposed to be a friendly environment.
– Rafael
Nov 23 '18 at 15:04




Seriously? A guy comes here looking for help and you tell him to go somewhere else? I thought stack overflow was supposed to be a friendly environment.
– Rafael
Nov 23 '18 at 15:04












1 Answer
1






active

oldest

votes


















2














One option would be to use an array of every field you're trying to get, and to figure out whether you want .visible or .hidden in advance:



const displayToUse = getField("Elect").valueAsString==="A"
? display.visible
: display.hidden;

[
'new_shares_A',
'new_shares_$_A',
'new_deb_A',
'new_deb_$_A',
'std_total_new_A'
].forEach((field) => {
this.getField(field).display = displayToUse;
});





share|improve this answer





















    Your Answer






    StackExchange.ifUsing("editor", function () {
    StackExchange.using("externalEditor", function () {
    StackExchange.using("snippets", function () {
    StackExchange.snippets.init();
    });
    });
    }, "code-snippets");

    StackExchange.ready(function() {
    var channelOptions = {
    tags: "".split(" "),
    id: "1"
    };
    initTagRenderer("".split(" "), "".split(" "), channelOptions);

    StackExchange.using("externalEditor", function() {
    // Have to fire editor after snippets, if snippets enabled
    if (StackExchange.settings.snippets.snippetsEnabled) {
    StackExchange.using("snippets", function() {
    createEditor();
    });
    }
    else {
    createEditor();
    }
    });

    function createEditor() {
    StackExchange.prepareEditor({
    heartbeatType: 'answer',
    autoActivateHeartbeat: false,
    convertImagesToLinks: true,
    noModals: true,
    showLowRepImageUploadWarning: true,
    reputationToPostImages: 10,
    bindNavPrevention: true,
    postfix: "",
    imageUploader: {
    brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
    contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
    allowUrls: true
    },
    onDemand: true,
    discardSelector: ".discard-answer"
    ,immediatelyShowMarkdownHelp:true
    });


    }
    });














    draft saved

    draft discarded


















    StackExchange.ready(
    function () {
    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53440186%2fdry-javascript-for-a-real-newbie%23new-answer', 'question_page');
    }
    );

    Post as a guest















    Required, but never shown

























    1 Answer
    1






    active

    oldest

    votes








    1 Answer
    1






    active

    oldest

    votes









    active

    oldest

    votes






    active

    oldest

    votes









    2














    One option would be to use an array of every field you're trying to get, and to figure out whether you want .visible or .hidden in advance:



    const displayToUse = getField("Elect").valueAsString==="A"
    ? display.visible
    : display.hidden;

    [
    'new_shares_A',
    'new_shares_$_A',
    'new_deb_A',
    'new_deb_$_A',
    'std_total_new_A'
    ].forEach((field) => {
    this.getField(field).display = displayToUse;
    });





    share|improve this answer


























      2














      One option would be to use an array of every field you're trying to get, and to figure out whether you want .visible or .hidden in advance:



      const displayToUse = getField("Elect").valueAsString==="A"
      ? display.visible
      : display.hidden;

      [
      'new_shares_A',
      'new_shares_$_A',
      'new_deb_A',
      'new_deb_$_A',
      'std_total_new_A'
      ].forEach((field) => {
      this.getField(field).display = displayToUse;
      });





      share|improve this answer
























        2












        2








        2






        One option would be to use an array of every field you're trying to get, and to figure out whether you want .visible or .hidden in advance:



        const displayToUse = getField("Elect").valueAsString==="A"
        ? display.visible
        : display.hidden;

        [
        'new_shares_A',
        'new_shares_$_A',
        'new_deb_A',
        'new_deb_$_A',
        'std_total_new_A'
        ].forEach((field) => {
        this.getField(field).display = displayToUse;
        });





        share|improve this answer












        One option would be to use an array of every field you're trying to get, and to figure out whether you want .visible or .hidden in advance:



        const displayToUse = getField("Elect").valueAsString==="A"
        ? display.visible
        : display.hidden;

        [
        'new_shares_A',
        'new_shares_$_A',
        'new_deb_A',
        'new_deb_$_A',
        'std_total_new_A'
        ].forEach((field) => {
        this.getField(field).display = displayToUse;
        });






        share|improve this answer












        share|improve this answer



        share|improve this answer










        answered Nov 23 '18 at 3:11









        CertainPerformance

        76.9k143862




        76.9k143862






























            draft saved

            draft discarded




















































            Thanks for contributing an answer to Stack Overflow!


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.





            Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


            Please pay close attention to the following guidance:


            • Please be sure to answer the question. Provide details and share your research!

            But avoid



            • Asking for help, clarification, or responding to other answers.

            • Making statements based on opinion; back them up with references or personal experience.


            To learn more, see our tips on writing great answers.




            draft saved


            draft discarded














            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53440186%2fdry-javascript-for-a-real-newbie%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown





















































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown

































            Required, but never shown














            Required, but never shown












            Required, but never shown







            Required, but never shown







            Popular posts from this blog

            Berounka

            Sphinx de Gizeh

            Different font size/position of beamer's navigation symbols template's content depending on regular/plain...