Htykuut

I have duplicated control structures which are exactly the same, and the difference is how things happen inside. In particular, I don’t know how to deal with break, continue, and return. For example:

int f() {

  for (int i = 0; i < 10; i++) {

    for (int j = 0; j < 10; j++) {

      if (isFoo(i, j)) {

        // doSomethingF1

      } else {

        // doSomethingF2

      }

    }

  }

}



int g() {

  for (int i = 0; i < 10; i++) {

    for (int j = 0; j < 10; j++) {

      if (isFoo(i, j)) {

        // doSomethingG1

      } else {

        // doSomethingG2

      }

    }

  }

}

where doSomethings rely on i and j, and need to break or continue through the j loop, and return out of the function. How do I factor this out to get rid of the duplication?

I thought of writing a function that would take the doSomethings as arguments, but I'm not sure how to deal with the breaks, continues, or returns.

[I'm not fine with the duplication since there are some checks on i and j in f(), g(), and like four other functions that are exactly the same; the only difference is a few lines of code.]

If you really want/insist to have the same inner control in the loop context with break, continue, and return then the proposed solution is macros :-(.

On the other hand, if the doSomethingFG12 functions all have a defined interface, then compliment your generic control structure to handle the case with break, continue, and return to make a choice from there return values.