What is the correct way of return a List in Spring












0














I have written a method which annotated with a Spring.it will return a List. following code snip will represent that method.



   @RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
public ResponseEntity<ReservationResponse> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {

return new ResponseEntity<>(new ReservationResponse(), HttpStatus.OK);
}


What i want to know is if i write it as this will it be a wrong?



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
public ResponseEntity<ReservationResponse> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {
ResponseEntity<ReservationResponse> reservationResponse = new ResponseEntity<ReservationResponse>();
return (reservationResponse, HttpStatus.OK);
}









share|improve this question






















  • I don't see any list. The second one is definitely wrong because that would become a ResponseEntity holding no response (i.e. it is empty). The first one is suspicious too, since you have created a new response object which probably has nothing.
    – Jai
    Nov 23 '18 at 7:05










  • Yes. i dont created any list here. i want to know whether returning ways are ok or not. adding list should be their for sure.
    – L.Anush
    Nov 23 '18 at 7:09
















0














I have written a method which annotated with a Spring.it will return a List. following code snip will represent that method.



   @RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
public ResponseEntity<ReservationResponse> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {

return new ResponseEntity<>(new ReservationResponse(), HttpStatus.OK);
}


What i want to know is if i write it as this will it be a wrong?



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
public ResponseEntity<ReservationResponse> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {
ResponseEntity<ReservationResponse> reservationResponse = new ResponseEntity<ReservationResponse>();
return (reservationResponse, HttpStatus.OK);
}









share|improve this question






















  • I don't see any list. The second one is definitely wrong because that would become a ResponseEntity holding no response (i.e. it is empty). The first one is suspicious too, since you have created a new response object which probably has nothing.
    – Jai
    Nov 23 '18 at 7:05










  • Yes. i dont created any list here. i want to know whether returning ways are ok or not. adding list should be their for sure.
    – L.Anush
    Nov 23 '18 at 7:09














0












0








0







I have written a method which annotated with a Spring.it will return a List. following code snip will represent that method.



   @RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
public ResponseEntity<ReservationResponse> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {

return new ResponseEntity<>(new ReservationResponse(), HttpStatus.OK);
}


What i want to know is if i write it as this will it be a wrong?



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
public ResponseEntity<ReservationResponse> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {
ResponseEntity<ReservationResponse> reservationResponse = new ResponseEntity<ReservationResponse>();
return (reservationResponse, HttpStatus.OK);
}









share|improve this question













I have written a method which annotated with a Spring.it will return a List. following code snip will represent that method.



   @RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
public ResponseEntity<ReservationResponse> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {

return new ResponseEntity<>(new ReservationResponse(), HttpStatus.OK);
}


What i want to know is if i write it as this will it be a wrong?



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
public ResponseEntity<ReservationResponse> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {
ResponseEntity<ReservationResponse> reservationResponse = new ResponseEntity<ReservationResponse>();
return (reservationResponse, HttpStatus.OK);
}






java spring list data-structures






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked Nov 23 '18 at 6:49









L.AnushL.Anush

387




387












  • I don't see any list. The second one is definitely wrong because that would become a ResponseEntity holding no response (i.e. it is empty). The first one is suspicious too, since you have created a new response object which probably has nothing.
    – Jai
    Nov 23 '18 at 7:05










  • Yes. i dont created any list here. i want to know whether returning ways are ok or not. adding list should be their for sure.
    – L.Anush
    Nov 23 '18 at 7:09


















  • I don't see any list. The second one is definitely wrong because that would become a ResponseEntity holding no response (i.e. it is empty). The first one is suspicious too, since you have created a new response object which probably has nothing.
    – Jai
    Nov 23 '18 at 7:05










  • Yes. i dont created any list here. i want to know whether returning ways are ok or not. adding list should be their for sure.
    – L.Anush
    Nov 23 '18 at 7:09
















I don't see any list. The second one is definitely wrong because that would become a ResponseEntity holding no response (i.e. it is empty). The first one is suspicious too, since you have created a new response object which probably has nothing.
– Jai
Nov 23 '18 at 7:05




I don't see any list. The second one is definitely wrong because that would become a ResponseEntity holding no response (i.e. it is empty). The first one is suspicious too, since you have created a new response object which probably has nothing.
– Jai
Nov 23 '18 at 7:05












Yes. i dont created any list here. i want to know whether returning ways are ok or not. adding list should be their for sure.
– L.Anush
Nov 23 '18 at 7:09




Yes. i dont created any list here. i want to know whether returning ways are ok or not. adding list should be their for sure.
– L.Anush
Nov 23 '18 at 7:09












1 Answer
1






active

oldest

votes


















1














I think your ReservationResponse contains a list like this:



class ReservationResponse{
List<Rooms> availableRooms;
}


If like this then you can just return ReservationResponse no need to add anything.



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
@ResponseBody
public ReservationResponse getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {
ReservationResponse> reservationResponse = new ReservationResponse();
List<Rooms> rooms = yourService.getAvailableRooms(checkIn,checkOut);
reservationResponse.setAvailableRooms(rooms);
return reservationResponse;
}


or you can simply return rooms like this



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
@ResponseBody
public List<Rooms> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {

List<Rooms> rooms = yourService.getAvailableRooms(checkIn,checkOut);

return rooms;
}





share|improve this answer





















  • Actually ReservationResponse is a entity which contain private set of fields and getters and setters.
    – L.Anush
    Nov 23 '18 at 8:26










  • So you can use first one by adjusting with your service data.
    – flopcoder
    Nov 23 '18 at 10:43










  • Any logical or syntax errors in second one.
    – L.Anush
    Nov 26 '18 at 3:11










  • Yes here yourService not defined
    – flopcoder
    Nov 26 '18 at 3:36











Your Answer






StackExchange.ifUsing("editor", function () {
StackExchange.using("externalEditor", function () {
StackExchange.using("snippets", function () {
StackExchange.snippets.init();
});
});
}, "code-snippets");

StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "1"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});

function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});


}
});














draft saved

draft discarded


















StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53441870%2fwhat-is-the-correct-way-of-return-a-list-in-spring%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes









1














I think your ReservationResponse contains a list like this:



class ReservationResponse{
List<Rooms> availableRooms;
}


If like this then you can just return ReservationResponse no need to add anything.



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
@ResponseBody
public ReservationResponse getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {
ReservationResponse> reservationResponse = new ReservationResponse();
List<Rooms> rooms = yourService.getAvailableRooms(checkIn,checkOut);
reservationResponse.setAvailableRooms(rooms);
return reservationResponse;
}


or you can simply return rooms like this



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
@ResponseBody
public List<Rooms> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {

List<Rooms> rooms = yourService.getAvailableRooms(checkIn,checkOut);

return rooms;
}





share|improve this answer





















  • Actually ReservationResponse is a entity which contain private set of fields and getters and setters.
    – L.Anush
    Nov 23 '18 at 8:26










  • So you can use first one by adjusting with your service data.
    – flopcoder
    Nov 23 '18 at 10:43










  • Any logical or syntax errors in second one.
    – L.Anush
    Nov 26 '18 at 3:11










  • Yes here yourService not defined
    – flopcoder
    Nov 26 '18 at 3:36
















1














I think your ReservationResponse contains a list like this:



class ReservationResponse{
List<Rooms> availableRooms;
}


If like this then you can just return ReservationResponse no need to add anything.



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
@ResponseBody
public ReservationResponse getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {
ReservationResponse> reservationResponse = new ReservationResponse();
List<Rooms> rooms = yourService.getAvailableRooms(checkIn,checkOut);
reservationResponse.setAvailableRooms(rooms);
return reservationResponse;
}


or you can simply return rooms like this



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
@ResponseBody
public List<Rooms> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {

List<Rooms> rooms = yourService.getAvailableRooms(checkIn,checkOut);

return rooms;
}





share|improve this answer





















  • Actually ReservationResponse is a entity which contain private set of fields and getters and setters.
    – L.Anush
    Nov 23 '18 at 8:26










  • So you can use first one by adjusting with your service data.
    – flopcoder
    Nov 23 '18 at 10:43










  • Any logical or syntax errors in second one.
    – L.Anush
    Nov 26 '18 at 3:11










  • Yes here yourService not defined
    – flopcoder
    Nov 26 '18 at 3:36














1












1








1






I think your ReservationResponse contains a list like this:



class ReservationResponse{
List<Rooms> availableRooms;
}


If like this then you can just return ReservationResponse no need to add anything.



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
@ResponseBody
public ReservationResponse getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {
ReservationResponse> reservationResponse = new ReservationResponse();
List<Rooms> rooms = yourService.getAvailableRooms(checkIn,checkOut);
reservationResponse.setAvailableRooms(rooms);
return reservationResponse;
}


or you can simply return rooms like this



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
@ResponseBody
public List<Rooms> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {

List<Rooms> rooms = yourService.getAvailableRooms(checkIn,checkOut);

return rooms;
}





share|improve this answer












I think your ReservationResponse contains a list like this:



class ReservationResponse{
List<Rooms> availableRooms;
}


If like this then you can just return ReservationResponse no need to add anything.



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
@ResponseBody
public ReservationResponse getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {
ReservationResponse> reservationResponse = new ReservationResponse();
List<Rooms> rooms = yourService.getAvailableRooms(checkIn,checkOut);
reservationResponse.setAvailableRooms(rooms);
return reservationResponse;
}


or you can simply return rooms like this



@RequestMapping(path = "", method = RequestMethod.GET, produces = MediaType.APPLICATION_JSON_UTF8_VALUE)
@ResponseBody
public List<Rooms> getAvailableRooms(
@RequestParam(name = "checkin")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkin,
@RequestParam(name = "checkout")
@DateTimeFormat(iso = DateTimeFormat.ISO.DATE)
LocalDate checkout) {

List<Rooms> rooms = yourService.getAvailableRooms(checkIn,checkOut);

return rooms;
}






share|improve this answer












share|improve this answer



share|improve this answer










answered Nov 23 '18 at 7:34









flopcoderflopcoder

735512




735512












  • Actually ReservationResponse is a entity which contain private set of fields and getters and setters.
    – L.Anush
    Nov 23 '18 at 8:26










  • So you can use first one by adjusting with your service data.
    – flopcoder
    Nov 23 '18 at 10:43










  • Any logical or syntax errors in second one.
    – L.Anush
    Nov 26 '18 at 3:11










  • Yes here yourService not defined
    – flopcoder
    Nov 26 '18 at 3:36


















  • Actually ReservationResponse is a entity which contain private set of fields and getters and setters.
    – L.Anush
    Nov 23 '18 at 8:26










  • So you can use first one by adjusting with your service data.
    – flopcoder
    Nov 23 '18 at 10:43










  • Any logical or syntax errors in second one.
    – L.Anush
    Nov 26 '18 at 3:11










  • Yes here yourService not defined
    – flopcoder
    Nov 26 '18 at 3:36
















Actually ReservationResponse is a entity which contain private set of fields and getters and setters.
– L.Anush
Nov 23 '18 at 8:26




Actually ReservationResponse is a entity which contain private set of fields and getters and setters.
– L.Anush
Nov 23 '18 at 8:26












So you can use first one by adjusting with your service data.
– flopcoder
Nov 23 '18 at 10:43




So you can use first one by adjusting with your service data.
– flopcoder
Nov 23 '18 at 10:43












Any logical or syntax errors in second one.
– L.Anush
Nov 26 '18 at 3:11




Any logical or syntax errors in second one.
– L.Anush
Nov 26 '18 at 3:11












Yes here yourService not defined
– flopcoder
Nov 26 '18 at 3:36




Yes here yourService not defined
– flopcoder
Nov 26 '18 at 3:36


















draft saved

draft discarded




















































Thanks for contributing an answer to Stack Overflow!


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.





Some of your past answers have not been well-received, and you're in danger of being blocked from answering.


Please pay close attention to the following guidance:


  • Please be sure to answer the question. Provide details and share your research!

But avoid



  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53441870%2fwhat-is-the-correct-way-of-return-a-list-in-spring%23new-answer', 'question_page');
}
);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Berounka

Sphinx de Gizeh

Different font size/position of beamer's navigation symbols template's content depending on regular/plain...