Combining multiple async actions that have independent reducers











up vote
0
down vote

favorite












I have two action files. book_actions.js and author_actions.js. They have their own reducers file as well.



When I fetch an author, it returns me a list of book ids. I would then like to fetch all these books.



author_actions.js
export const fetchAuthorAndBooks = (authorId) => (dispatch: Dispatch) => {
fetchAuthor(authorId).then((author) => {
author.bookIds.each((id) => {
dispatch(fetchBook(id))
})
});

}


I want to wait for the author and the book fetching to complete before rendering anything on screen. To accopmbilish this I was going
to add a loading flag on each reducer state. Then when nothing is loading, render the components with all the data that was returned



Is this the correct way to handle multiple async calls on different actions files? It seems wrong to add a loading property in each reducer
just for this. Should I be doing this in author_actions.js or a container component which dispatches these actions?










share|improve this question


























    up vote
    0
    down vote

    favorite












    I have two action files. book_actions.js and author_actions.js. They have their own reducers file as well.



    When I fetch an author, it returns me a list of book ids. I would then like to fetch all these books.



    author_actions.js
    export const fetchAuthorAndBooks = (authorId) => (dispatch: Dispatch) => {
    fetchAuthor(authorId).then((author) => {
    author.bookIds.each((id) => {
    dispatch(fetchBook(id))
    })
    });

    }


    I want to wait for the author and the book fetching to complete before rendering anything on screen. To accopmbilish this I was going
    to add a loading flag on each reducer state. Then when nothing is loading, render the components with all the data that was returned



    Is this the correct way to handle multiple async calls on different actions files? It seems wrong to add a loading property in each reducer
    just for this. Should I be doing this in author_actions.js or a container component which dispatches these actions?










    share|improve this question
























      up vote
      0
      down vote

      favorite









      up vote
      0
      down vote

      favorite











      I have two action files. book_actions.js and author_actions.js. They have their own reducers file as well.



      When I fetch an author, it returns me a list of book ids. I would then like to fetch all these books.



      author_actions.js
      export const fetchAuthorAndBooks = (authorId) => (dispatch: Dispatch) => {
      fetchAuthor(authorId).then((author) => {
      author.bookIds.each((id) => {
      dispatch(fetchBook(id))
      })
      });

      }


      I want to wait for the author and the book fetching to complete before rendering anything on screen. To accopmbilish this I was going
      to add a loading flag on each reducer state. Then when nothing is loading, render the components with all the data that was returned



      Is this the correct way to handle multiple async calls on different actions files? It seems wrong to add a loading property in each reducer
      just for this. Should I be doing this in author_actions.js or a container component which dispatches these actions?










      share|improve this question













      I have two action files. book_actions.js and author_actions.js. They have their own reducers file as well.



      When I fetch an author, it returns me a list of book ids. I would then like to fetch all these books.



      author_actions.js
      export const fetchAuthorAndBooks = (authorId) => (dispatch: Dispatch) => {
      fetchAuthor(authorId).then((author) => {
      author.bookIds.each((id) => {
      dispatch(fetchBook(id))
      })
      });

      }


      I want to wait for the author and the book fetching to complete before rendering anything on screen. To accopmbilish this I was going
      to add a loading flag on each reducer state. Then when nothing is loading, render the components with all the data that was returned



      Is this the correct way to handle multiple async calls on different actions files? It seems wrong to add a loading property in each reducer
      just for this. Should I be doing this in author_actions.js or a container component which dispatches these actions?







      reactjs redux redux-thunk






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 20 at 23:34









      Decrypter

      1,15692446




      1,15692446
























          1 Answer
          1






          active

          oldest

          votes

















          up vote
          2
          down vote













          I would check if the API you are using has an endpoint like authors/:id/books. If an author has 100 books, I don't think it is very performant to make 100 API calls. There should be an endpoint like I described that would return all of the books for the author.



          An alternative approach if you cannot access an endpoint like that, would be to try using something like Promise.all, which only returns one Promise depending on the result of several Promises passed to it. Perhaps you could create a new method that accepts an array of the book id's:



          function fetchAuthorBooks(ids) {
          return Promise.all(ids.map(id => axios.get(`/books/${id}`)))
          }


          usage:



          fetchAuthorBooks(author.bookIds).then((books) => {
          // the array of books
          }).catch((err) => {
          // one of the requests failed
          })


          Hopefully, this gives you some direction! I would really lean towards finding out if that endpoint is available.






          share|improve this answer





















            Your Answer






            StackExchange.ifUsing("editor", function () {
            StackExchange.using("externalEditor", function () {
            StackExchange.using("snippets", function () {
            StackExchange.snippets.init();
            });
            });
            }, "code-snippets");

            StackExchange.ready(function() {
            var channelOptions = {
            tags: "".split(" "),
            id: "1"
            };
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function() {
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled) {
            StackExchange.using("snippets", function() {
            createEditor();
            });
            }
            else {
            createEditor();
            }
            });

            function createEditor() {
            StackExchange.prepareEditor({
            heartbeatType: 'answer',
            convertImagesToLinks: true,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: 10,
            bindNavPrevention: true,
            postfix: "",
            imageUploader: {
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            },
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            });


            }
            });














             

            draft saved


            draft discarded


















            StackExchange.ready(
            function () {
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53403202%2fcombining-multiple-async-actions-that-have-independent-reducers%23new-answer', 'question_page');
            }
            );

            Post as a guest















            Required, but never shown

























            1 Answer
            1






            active

            oldest

            votes








            1 Answer
            1






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes








            up vote
            2
            down vote













            I would check if the API you are using has an endpoint like authors/:id/books. If an author has 100 books, I don't think it is very performant to make 100 API calls. There should be an endpoint like I described that would return all of the books for the author.



            An alternative approach if you cannot access an endpoint like that, would be to try using something like Promise.all, which only returns one Promise depending on the result of several Promises passed to it. Perhaps you could create a new method that accepts an array of the book id's:



            function fetchAuthorBooks(ids) {
            return Promise.all(ids.map(id => axios.get(`/books/${id}`)))
            }


            usage:



            fetchAuthorBooks(author.bookIds).then((books) => {
            // the array of books
            }).catch((err) => {
            // one of the requests failed
            })


            Hopefully, this gives you some direction! I would really lean towards finding out if that endpoint is available.






            share|improve this answer

























              up vote
              2
              down vote













              I would check if the API you are using has an endpoint like authors/:id/books. If an author has 100 books, I don't think it is very performant to make 100 API calls. There should be an endpoint like I described that would return all of the books for the author.



              An alternative approach if you cannot access an endpoint like that, would be to try using something like Promise.all, which only returns one Promise depending on the result of several Promises passed to it. Perhaps you could create a new method that accepts an array of the book id's:



              function fetchAuthorBooks(ids) {
              return Promise.all(ids.map(id => axios.get(`/books/${id}`)))
              }


              usage:



              fetchAuthorBooks(author.bookIds).then((books) => {
              // the array of books
              }).catch((err) => {
              // one of the requests failed
              })


              Hopefully, this gives you some direction! I would really lean towards finding out if that endpoint is available.






              share|improve this answer























                up vote
                2
                down vote










                up vote
                2
                down vote









                I would check if the API you are using has an endpoint like authors/:id/books. If an author has 100 books, I don't think it is very performant to make 100 API calls. There should be an endpoint like I described that would return all of the books for the author.



                An alternative approach if you cannot access an endpoint like that, would be to try using something like Promise.all, which only returns one Promise depending on the result of several Promises passed to it. Perhaps you could create a new method that accepts an array of the book id's:



                function fetchAuthorBooks(ids) {
                return Promise.all(ids.map(id => axios.get(`/books/${id}`)))
                }


                usage:



                fetchAuthorBooks(author.bookIds).then((books) => {
                // the array of books
                }).catch((err) => {
                // one of the requests failed
                })


                Hopefully, this gives you some direction! I would really lean towards finding out if that endpoint is available.






                share|improve this answer












                I would check if the API you are using has an endpoint like authors/:id/books. If an author has 100 books, I don't think it is very performant to make 100 API calls. There should be an endpoint like I described that would return all of the books for the author.



                An alternative approach if you cannot access an endpoint like that, would be to try using something like Promise.all, which only returns one Promise depending on the result of several Promises passed to it. Perhaps you could create a new method that accepts an array of the book id's:



                function fetchAuthorBooks(ids) {
                return Promise.all(ids.map(id => axios.get(`/books/${id}`)))
                }


                usage:



                fetchAuthorBooks(author.bookIds).then((books) => {
                // the array of books
                }).catch((err) => {
                // one of the requests failed
                })


                Hopefully, this gives you some direction! I would really lean towards finding out if that endpoint is available.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered 2 days ago









                Nitsew

                1,054912




                1,054912






























                     

                    draft saved


                    draft discarded



















































                     


                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function () {
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53403202%2fcombining-multiple-async-actions-that-have-independent-reducers%23new-answer', 'question_page');
                    }
                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    Berounka

                    Sphinx de Gizeh

                    Different font size/position of beamer's navigation symbols template's content depending on regular/plain...