Using a decorator to save matplotlib graphs; saved output is blank












0















I'm trying to create a decorator function @save_fig to wrap around a matplotlib function (plot_this()) in order to automatically save the output.



I can get the decorator to execute correctly and show/display the graph. However, when the plt.savefig() is evaluated a blank graph is saved to my directory.



I'm wondering what I'm missing with the logic in my decorator code? The output should be completely reproducible from my code below.



Thank you



import matplotlib.pyplot as plt
import pandas as pd

df = pd.DataFrame(data={'foo':list(range(5)), 'bar':list(range(5, 10, 1))})

def save_fig(**param):
def outer(func):
def inner(*args, **kwargs):
ax = func(*args)
if 'filename' in param.keys():
print('filename')
plt.savefig(param['filename'])
elif 'show' in param.keys():
print('show')
plt.show()
else:
return ax
return inner
return outer

@save_fig(**{'filename': 'foo.png'})
def plot_this():
plt.scatter(df['foo'], df['bar'])
plt.show()

if __name__ == "__main__":
plot_this()









share|improve this question



























    0















    I'm trying to create a decorator function @save_fig to wrap around a matplotlib function (plot_this()) in order to automatically save the output.



    I can get the decorator to execute correctly and show/display the graph. However, when the plt.savefig() is evaluated a blank graph is saved to my directory.



    I'm wondering what I'm missing with the logic in my decorator code? The output should be completely reproducible from my code below.



    Thank you



    import matplotlib.pyplot as plt
    import pandas as pd

    df = pd.DataFrame(data={'foo':list(range(5)), 'bar':list(range(5, 10, 1))})

    def save_fig(**param):
    def outer(func):
    def inner(*args, **kwargs):
    ax = func(*args)
    if 'filename' in param.keys():
    print('filename')
    plt.savefig(param['filename'])
    elif 'show' in param.keys():
    print('show')
    plt.show()
    else:
    return ax
    return inner
    return outer

    @save_fig(**{'filename': 'foo.png'})
    def plot_this():
    plt.scatter(df['foo'], df['bar'])
    plt.show()

    if __name__ == "__main__":
    plot_this()









    share|improve this question

























      0












      0








      0








      I'm trying to create a decorator function @save_fig to wrap around a matplotlib function (plot_this()) in order to automatically save the output.



      I can get the decorator to execute correctly and show/display the graph. However, when the plt.savefig() is evaluated a blank graph is saved to my directory.



      I'm wondering what I'm missing with the logic in my decorator code? The output should be completely reproducible from my code below.



      Thank you



      import matplotlib.pyplot as plt
      import pandas as pd

      df = pd.DataFrame(data={'foo':list(range(5)), 'bar':list(range(5, 10, 1))})

      def save_fig(**param):
      def outer(func):
      def inner(*args, **kwargs):
      ax = func(*args)
      if 'filename' in param.keys():
      print('filename')
      plt.savefig(param['filename'])
      elif 'show' in param.keys():
      print('show')
      plt.show()
      else:
      return ax
      return inner
      return outer

      @save_fig(**{'filename': 'foo.png'})
      def plot_this():
      plt.scatter(df['foo'], df['bar'])
      plt.show()

      if __name__ == "__main__":
      plot_this()









      share|improve this question














      I'm trying to create a decorator function @save_fig to wrap around a matplotlib function (plot_this()) in order to automatically save the output.



      I can get the decorator to execute correctly and show/display the graph. However, when the plt.savefig() is evaluated a blank graph is saved to my directory.



      I'm wondering what I'm missing with the logic in my decorator code? The output should be completely reproducible from my code below.



      Thank you



      import matplotlib.pyplot as plt
      import pandas as pd

      df = pd.DataFrame(data={'foo':list(range(5)), 'bar':list(range(5, 10, 1))})

      def save_fig(**param):
      def outer(func):
      def inner(*args, **kwargs):
      ax = func(*args)
      if 'filename' in param.keys():
      print('filename')
      plt.savefig(param['filename'])
      elif 'show' in param.keys():
      print('show')
      plt.show()
      else:
      return ax
      return inner
      return outer

      @save_fig(**{'filename': 'foo.png'})
      def plot_this():
      plt.scatter(df['foo'], df['bar'])
      plt.show()

      if __name__ == "__main__":
      plot_this()






      python pandas matplotlib python-decorators






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked Nov 23 '18 at 16:02









      Chef1075Chef1075

      1,11131829




      1,11131829
























          1 Answer
          1






          active

          oldest

          votes


















          0














          You call show before saving the figure. The figure that is saved is hence a new empty figure. Since you handle show inside the decorator anyways, you can just leave it out.



          import matplotlib.pyplot as plt
          import pandas as pd

          df = pd.DataFrame(data={'foo':list(range(5)), 'bar':list(range(5, 10, 1))})

          def save_fig(**param):
          def outer(func):
          def inner(*args, **kwargs):
          artist = func(*args)
          if 'filename' in param.keys():
          print('filename')
          plt.savefig(param['filename'])
          if 'show' in param.keys() and param["show"]:
          print('show')
          plt.show()
          else:
          return artist
          return inner
          return outer

          @save_fig(**{'filename': 'foo.png', 'show' : True})
          def plot_this():
          return plt.scatter(df['foo'], df['bar'])


          if __name__ == "__main__":
          plot_this()





          share|improve this answer
























          • Ah I see what I did wrong here. Thanks!

            – Chef1075
            Nov 23 '18 at 18:40











          Your Answer






          StackExchange.ifUsing("editor", function () {
          StackExchange.using("externalEditor", function () {
          StackExchange.using("snippets", function () {
          StackExchange.snippets.init();
          });
          });
          }, "code-snippets");

          StackExchange.ready(function() {
          var channelOptions = {
          tags: "".split(" "),
          id: "1"
          };
          initTagRenderer("".split(" "), "".split(" "), channelOptions);

          StackExchange.using("externalEditor", function() {
          // Have to fire editor after snippets, if snippets enabled
          if (StackExchange.settings.snippets.snippetsEnabled) {
          StackExchange.using("snippets", function() {
          createEditor();
          });
          }
          else {
          createEditor();
          }
          });

          function createEditor() {
          StackExchange.prepareEditor({
          heartbeatType: 'answer',
          autoActivateHeartbeat: false,
          convertImagesToLinks: true,
          noModals: true,
          showLowRepImageUploadWarning: true,
          reputationToPostImages: 10,
          bindNavPrevention: true,
          postfix: "",
          imageUploader: {
          brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
          contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
          allowUrls: true
          },
          onDemand: true,
          discardSelector: ".discard-answer"
          ,immediatelyShowMarkdownHelp:true
          });


          }
          });














          draft saved

          draft discarded


















          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53449782%2fusing-a-decorator-to-save-matplotlib-graphs-saved-output-is-blank%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown

























          1 Answer
          1






          active

          oldest

          votes








          1 Answer
          1






          active

          oldest

          votes









          active

          oldest

          votes






          active

          oldest

          votes









          0














          You call show before saving the figure. The figure that is saved is hence a new empty figure. Since you handle show inside the decorator anyways, you can just leave it out.



          import matplotlib.pyplot as plt
          import pandas as pd

          df = pd.DataFrame(data={'foo':list(range(5)), 'bar':list(range(5, 10, 1))})

          def save_fig(**param):
          def outer(func):
          def inner(*args, **kwargs):
          artist = func(*args)
          if 'filename' in param.keys():
          print('filename')
          plt.savefig(param['filename'])
          if 'show' in param.keys() and param["show"]:
          print('show')
          plt.show()
          else:
          return artist
          return inner
          return outer

          @save_fig(**{'filename': 'foo.png', 'show' : True})
          def plot_this():
          return plt.scatter(df['foo'], df['bar'])


          if __name__ == "__main__":
          plot_this()





          share|improve this answer
























          • Ah I see what I did wrong here. Thanks!

            – Chef1075
            Nov 23 '18 at 18:40
















          0














          You call show before saving the figure. The figure that is saved is hence a new empty figure. Since you handle show inside the decorator anyways, you can just leave it out.



          import matplotlib.pyplot as plt
          import pandas as pd

          df = pd.DataFrame(data={'foo':list(range(5)), 'bar':list(range(5, 10, 1))})

          def save_fig(**param):
          def outer(func):
          def inner(*args, **kwargs):
          artist = func(*args)
          if 'filename' in param.keys():
          print('filename')
          plt.savefig(param['filename'])
          if 'show' in param.keys() and param["show"]:
          print('show')
          plt.show()
          else:
          return artist
          return inner
          return outer

          @save_fig(**{'filename': 'foo.png', 'show' : True})
          def plot_this():
          return plt.scatter(df['foo'], df['bar'])


          if __name__ == "__main__":
          plot_this()





          share|improve this answer
























          • Ah I see what I did wrong here. Thanks!

            – Chef1075
            Nov 23 '18 at 18:40














          0












          0








          0







          You call show before saving the figure. The figure that is saved is hence a new empty figure. Since you handle show inside the decorator anyways, you can just leave it out.



          import matplotlib.pyplot as plt
          import pandas as pd

          df = pd.DataFrame(data={'foo':list(range(5)), 'bar':list(range(5, 10, 1))})

          def save_fig(**param):
          def outer(func):
          def inner(*args, **kwargs):
          artist = func(*args)
          if 'filename' in param.keys():
          print('filename')
          plt.savefig(param['filename'])
          if 'show' in param.keys() and param["show"]:
          print('show')
          plt.show()
          else:
          return artist
          return inner
          return outer

          @save_fig(**{'filename': 'foo.png', 'show' : True})
          def plot_this():
          return plt.scatter(df['foo'], df['bar'])


          if __name__ == "__main__":
          plot_this()





          share|improve this answer













          You call show before saving the figure. The figure that is saved is hence a new empty figure. Since you handle show inside the decorator anyways, you can just leave it out.



          import matplotlib.pyplot as plt
          import pandas as pd

          df = pd.DataFrame(data={'foo':list(range(5)), 'bar':list(range(5, 10, 1))})

          def save_fig(**param):
          def outer(func):
          def inner(*args, **kwargs):
          artist = func(*args)
          if 'filename' in param.keys():
          print('filename')
          plt.savefig(param['filename'])
          if 'show' in param.keys() and param["show"]:
          print('show')
          plt.show()
          else:
          return artist
          return inner
          return outer

          @save_fig(**{'filename': 'foo.png', 'show' : True})
          def plot_this():
          return plt.scatter(df['foo'], df['bar'])


          if __name__ == "__main__":
          plot_this()






          share|improve this answer












          share|improve this answer



          share|improve this answer










          answered Nov 23 '18 at 18:02









          ImportanceOfBeingErnestImportanceOfBeingErnest

          128k12131208




          128k12131208













          • Ah I see what I did wrong here. Thanks!

            – Chef1075
            Nov 23 '18 at 18:40



















          • Ah I see what I did wrong here. Thanks!

            – Chef1075
            Nov 23 '18 at 18:40

















          Ah I see what I did wrong here. Thanks!

          – Chef1075
          Nov 23 '18 at 18:40





          Ah I see what I did wrong here. Thanks!

          – Chef1075
          Nov 23 '18 at 18:40


















          draft saved

          draft discarded




















































          Thanks for contributing an answer to Stack Overflow!


          • Please be sure to answer the question. Provide details and share your research!

          But avoid



          • Asking for help, clarification, or responding to other answers.

          • Making statements based on opinion; back them up with references or personal experience.


          To learn more, see our tips on writing great answers.




          draft saved


          draft discarded














          StackExchange.ready(
          function () {
          StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f53449782%2fusing-a-decorator-to-save-matplotlib-graphs-saved-output-is-blank%23new-answer', 'question_page');
          }
          );

          Post as a guest















          Required, but never shown





















































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown

































          Required, but never shown














          Required, but never shown












          Required, but never shown







          Required, but never shown







          Popular posts from this blog

          Berounka

          Sphinx de Gizeh

          Different font size/position of beamer's navigation symbols template's content depending on regular/plain...